]> dgit.raspbian.org Git - gnome-shell.git/commit
dbusServices/extensions: Override destroy() method
authorFlorian Müllner <fmuellner@gnome.org>
Sun, 25 Feb 2024 20:22:22 +0000 (21:22 +0100)
committerMarge Bot <marge-bot@gnome.org>
Fri, 1 Mar 2024 15:00:46 +0000 (15:00 +0000)
commit1e882ba8dca09643f66c8a63f1f650257e1ae0b8
tree95cafe9531bb8acb997d07a358b3a904da8b29a0
parentdb490dbaf75b33f7fed59d9f89a0d5d209420dfb
dbusServices/extensions: Override destroy() method

Some extensions try to destroy the provided dialog, so they can
instead show the preferences in an alternative way.

Unfortunately that is undetectable from the Extensions service,
which still thinks the dialog is open, and will therefore block
other prefs dialogs.

Try to steer extensions away from that anti-pattern (or at the
very least switch to `close()` which doesn't break) by overriding
the window's destroy() method and show an extension error instead.

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7435

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3209>
js/dbusServices/extensions/extensionPrefsDialog.js